feat: seperate running_queries_count and active_sessions_count in /v1/status #12384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
github-actions
bot
added
the
pr-feature
zhang2014
approved these changes
Aug 9, 2023
andylokandy
pushed a commit
to andylokandy/databend
that referenced
this pull request
Nov 27, 2023
…/status (databendlabs#12384) * do not include idle session in runing_queries_count * add ProcessInfoState * tune comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/
Summary
I'm using /v1/status in to detect inactive query instances. There're few cases about the
running_queries_count > 0but they are actually in "Idle" state. If a query instance is full of Idle sessions, it's actually safe to shutdown it to reduce cost.This PR filtered out the
Idlesessions in therunning_queries_countfield, and added anotheractive_sessions_countfield to represent the active connections count.This change is