fix: memory leak in unsafe code #12446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
andylokandy
reviewed
Aug 13, 2023
| return Some(std::ptr::read(raw_ptr as *const Self)); | ||
| let raw_ptr = Box::into_raw(boxed) as *mut dyn BlockMetaInfo; | ||
| let typed_ptr = raw_ptr as *mut Self; | ||
| return Some(*Box::from_raw(typed_ptr)); |
There was a problem hiding this comment.
it'll be more consice if we write:
let downcast_box = std::mem::transmute::<Box<_>, Box<Self>>(boxed);
*downcast_boxThere was a problem hiding this comment.
Good idea! BTW, I want to discuss, what about removing unsafe code by writing somthing like boxed.into_any().downcast()
There was a problem hiding this comment.
it may be not able to take ownership from Box<Any>, but we can clone it anyway.
andylokandy
pushed a commit
to andylokandy/databend
that referenced
this pull request
Nov 27, 2023
* fix: memory leak in unsafe code * respect gpt advice
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/
Summary
Summary about this PR
This change is