Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: read parquet in row group level. #12569

Merged
merged 12 commits into from
Aug 25, 2023

Conversation

RinChanNOWWW
Copy link
Contributor

@RinChanNOWWW RinChanNOWWW commented Aug 24, 2023

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

  • Read parquet meta during read_partitions. Make one row group as one partition. Store row group meta in the partition.
  • Introduce InMemoryRowGroup to implement row group level reading.
  • Add scan_progress to parquet source and iceberg source to support recording reading progress.
  • Rename ParquetPart::SmallFiles to ParquetPart::Files. This kind of part can not only be used for small files.
  • Move Parquet2RowGroupPart and ParquetRSRowGroupPart to their own mods.
  • Wrap predicate evaluation into a method.

NOTES: Iceberg still read in parquet file level.

Tracking in #12465


This change is Reviewable

@vercel
Copy link

vercel bot commented Aug 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
databend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 25, 2023 7:53am

@RinChanNOWWW RinChanNOWWW marked this pull request as ready for review August 24, 2023 08:15
@github-actions github-actions bot added the pr-refactor this PR changes the code base without new features or bugfix label Aug 24, 2023
@RinChanNOWWW RinChanNOWWW marked this pull request as draft August 25, 2023 07:40
@RinChanNOWWW RinChanNOWWW marked this pull request as ready for review August 25, 2023 07:50
@BohuTANG BohuTANG merged commit ccc2d5c into databendlabs:main Aug 25, 2023
@RinChanNOWWW RinChanNOWWW deleted the row-group-reader branch August 28, 2023 02:41
andylokandy pushed a commit to andylokandy/databend that referenced this pull request Nov 27, 2023
* Implemnt row group level reading for parquet reader.

* Change parquet rs part to row group level.

* Move specific part to specific mod.

* Change parquet reading from stream to batch read.

* Iceberg use parquet files part.

* Suppot prewhere.

* Fix.

* Add progress record.

* Fix stats collection.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-refactor this PR changes the code base without new features or bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants