-
Notifications
You must be signed in to change notification settings - Fork 761
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: read parquet in row group level. #12569
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
8 tasks
RinChanNOWWW
force-pushed
the
row-group-reader
branch
from
August 24, 2023 03:40
d4675fe
to
59d81c1
Compare
RinChanNOWWW
force-pushed
the
row-group-reader
branch
from
August 24, 2023 08:13
e419c8e
to
3ab1744
Compare
github-actions
bot
added
the
pr-refactor
this PR changes the code base without new features or bugfix
label
Aug 24, 2023
RinChanNOWWW
force-pushed
the
row-group-reader
branch
from
August 24, 2023 08:49
3ab1744
to
b06d46f
Compare
RinChanNOWWW
force-pushed
the
row-group-reader
branch
from
August 24, 2023 11:18
b06d46f
to
c4a80e6
Compare
sundy-li
approved these changes
Aug 25, 2023
andylokandy
pushed a commit
to andylokandy/databend
that referenced
this pull request
Nov 27, 2023
* Implemnt row group level reading for parquet reader. * Change parquet rs part to row group level. * Move specific part to specific mod. * Change parquet reading from stream to batch read. * Iceberg use parquet files part. * Suppot prewhere. * Fix. * Add progress record. * Fix stats collection.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/
Summary
read_partitions
. Make one row group as one partition. Store row group meta in the partition.InMemoryRowGroup
to implement row group level reading.scan_progress
to parquet source and iceberg source to support recording reading progress.ParquetPart::SmallFiles
toParquetPart::Files
. This kind of part can not only be used for small files.Parquet2RowGroupPart
andParquetRSRowGroupPart
to their own mods.NOTES: Iceberg still read in parquet file level.
Tracking in #12465
This change is