Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(query): fix add/subtract datetime with big integer panic #12940

Merged
merged 4 commits into from
Sep 20, 2023

Conversation

b41sh
Copy link
Member

@b41sh b41sh commented Sep 20, 2023

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

  • fix add/subtract datetime with big integer panic
  • add to_quarter function

Closes #12911


This change is Reviewable

@vercel
Copy link

vercel bot commented Sep 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
databend ⬜️ Ignored (Inspect) Visit Preview Sep 20, 2023 10:48am

@github-actions github-actions bot added the pr-bugfix this PR patches a bug in codebase label Sep 20, 2023
Copy link
Contributor

@ariesdevil ariesdevil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@b41sh b41sh requested a review from sundy-li September 20, 2023 10:54
@BohuTANG BohuTANG merged commit 321b99b into databendlabs:main Sep 20, 2023
andylokandy pushed a commit to andylokandy/databend that referenced this pull request Nov 27, 2023
…dlabs#12940)

* fix(query): fix add/subtract datetime with big integer panic

* fix

* fix domain
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix this PR patches a bug in codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: add and minus date with big integer panic
4 participants