Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rename: SMV002::get_kv() to get_maybe_expired_kv() #13466

Merged
merged 3 commits into from
Oct 27, 2023

Conversation

drmingdrmer
Copy link
Member

@drmingdrmer drmingdrmer commented Oct 27, 2023

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

chore: rename: SMV002::get_kv() to get_maybe_expired_kv()

Because its return value may be an expired record and should be considered as None

chore: collect sys data API into SysData, reduce state machine API set

Changelog

Related Issues


This change is Reviewable

@vercel
Copy link

vercel bot commented Oct 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
databend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 27, 2023 3:32am

@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Oct 27, 2023
@drmingdrmer drmingdrmer marked this pull request as ready for review October 27, 2023 02:49
@drmingdrmer drmingdrmer enabled auto-merge October 27, 2023 03:41
@drmingdrmer drmingdrmer added this pull request to the merge queue Oct 27, 2023
Merged via the queue into databendlabs:main with commit 081af95 Oct 27, 2023
@drmingdrmer drmingdrmer deleted the 34-map-stream-2 branch October 27, 2023 04:23
andylokandy pushed a commit to andylokandy/databend that referenced this pull request Nov 27, 2023
…bs#13466)

* chore: collect sys data API into SysData, reduce state machine API set

* chore: rename: SMV002::get_kv() to get_maybe_expired_kv()

Because its return value may be an expired record and should be considered as None
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-chore this PR only has small changes that no need to record, like coding styles.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants