Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not panic, instead, return an error when all retry attempts have been used up #13660

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

drmingdrmer
Copy link
Member

@drmingdrmer drmingdrmer commented Nov 9, 2023

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

fix: do not panic, instead, return an error when all retry attempts have been used up

Changelog

  • Bug Fix

Related Issues


This change is Reviewable

@github-actions github-actions bot added the pr-bugfix this PR patches a bug in codebase label Nov 9, 2023
@drmingdrmer drmingdrmer marked this pull request as ready for review November 9, 2023 13:51
@drmingdrmer drmingdrmer added this pull request to the merge queue Nov 9, 2023
@BohuTANG BohuTANG removed this pull request from the merge queue due to a manual request Nov 9, 2023
@BohuTANG BohuTANG merged commit 031010f into databendlabs:main Nov 9, 2023
@drmingdrmer drmingdrmer deleted the 31-fix-retry branch November 9, 2023 14:21
andylokandy pushed a commit to andylokandy/databend that referenced this pull request Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix this PR patches a bug in codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants