fix: fix order by contains count in scalar subquery #13782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dousir9
approved these changes
Nov 22, 2023
Dousir9
reviewed
Nov 22, 2023
src/query/sql/src/planner/optimizer/heuristic/decorrelate/flatten_plan.rs
Outdated
Show resolved
Hide resolved
xudong963
commented
Nov 22, 2023
src/query/sql/src/planner/optimizer/heuristic/decorrelate/flatten_plan.rs
Outdated
Show resolved
Hide resolved
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
andylokandy
pushed a commit
to andylokandy/databend
that referenced
this pull request
Nov 27, 2023
* fix: fix order by contains count in scalar subquery * Update src/query/sql/src/planner/optimizer/heuristic/decorrelate/flatten_plan.rs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/
Summary
In scalar subquery, if the aggregation function comes from order by , no
if_not_nullconversion is needed.This change is