Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support abs for decimal types #14195

Merged
merged 3 commits into from
Jan 2, 2024
Merged

Conversation

sundy-li
Copy link
Member

@sundy-li sundy-li commented Jan 2, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

Briefly describe what this PR aims to solve. Include background context that will help reviewers understand the purpose of the PR.

Decimal types support abs function
Disable auto cast from decimal to f32

Fixes #14189

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@sundy-li sundy-li requested a review from andylokandy January 2, 2024 02:16
@github-actions github-actions bot added the pr-feature this PR introduces a new feature to the codebase label Jan 2, 2024
@sundy-li sundy-li requested a review from b41sh January 2, 2024 02:17
@BohuTANG BohuTANG merged commit c505800 into databendlabs:main Jan 2, 2024
71 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: numeric functions combine result is not right
3 participants