refactor: Remove Compatible error
#14198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
pr-refactor
`Compatible` error is added in 0.9.41 to accept two types of error returned from meta-service: `KVAppError` and `MetaAPIError`. Such compatible layer can be removed since meta-client's min compatible meta-service version has already increased to a newer version which does not send `KVAppError` any more.
drmingdrmer
force-pushed
the
53-rm-compat-err
branch
from
c880dad to
a58bbad
Compare
BohuTANG
approved these changes
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
refactor: Remove
CompatibleerrorCompatibleerror is added in 0.9.41 to accept two types of errorreturned from meta-service:
KVAppErrorandMetaAPIError.Such compatible layer can be removed since meta-client's min compatible
meta-service version has already increased to a newer version which does
not send
KVAppErrorany more.Changelog
Related Issues
This change is