Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: system table add query_log.log_type_name and cluster.cluster_id #14545

Merged
merged 3 commits into from
Feb 1, 2024

Conversation

BohuTANG
Copy link
Member

@BohuTANG BohuTANG commented Feb 1, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

  • add log_type_name to system.log_query table, make the query log type more readable
  • add cluster to system.cluster, make the node belongs to which cluster more readable
  • change http handler execute_steate.rs stop log level from info to warn @youngsofun

Fixes #14542

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-feature this PR introduces a new feature to the codebase label Feb 1, 2024
@BohuTANG
Copy link
Member Author

BohuTANG commented Feb 1, 2024

tests/suites/1_stateful/02_query/02_0006_system_table_query_speed.py formatted by my lint.

@BohuTANG BohuTANG requested a review from sundy-li February 1, 2024 07:56
@BohuTANG BohuTANG marked this pull request as ready for review February 1, 2024 08:02
@BohuTANG
Copy link
Member Author

BohuTANG commented Feb 1, 2024

The failure is not related to this PR:

--- /runner/_work/databend/databend/tests/suites/1_stateful/02_query/02_0006_system_table_query_speed.result	2024-02-01 07:56:33.242428701 +0000
+++ /runner/_work/databend/databend/tests/suites/1_stateful/02_query/02_0006_system_table_query_speed.stdout	2024-02-01 07:59:45.126391901 +0000
@@ -1,2 +1,2 @@
-normal
+Err: query system.tables in one db cost exception, cost: 0:00:00.108309

@BohuTANG BohuTANG merged commit 27475ff into databendlabs:main Feb 1, 2024
81 of 83 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: add log_type_name to log_query table
1 participant