Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(query): integrate hash join with new filter framework #14689

Merged
merged 13 commits into from
Feb 26, 2024

Conversation

Dousir9
Copy link
Member

@Dousir9 Dousir9 commented Feb 20, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

Integrate hash join with new filter framework to handle other predicates in hash join, left / right mark join are temporarily unable to integrate new filter.

Benchmark

Test SQL

SELECT
  l_orderkey,
  l_shipdate,
  o_orderdate,
  o_shippriority
FROM
  lineitem
  LEFT JOIN orders ON l_orderkey = o_orderkey
  AND l_shipdate > to_date('1995-03-15')
  AND l_shipdate < to_date('1999-03-15')
ORDER BY
  o_orderdate
LIMIT
  5

Before
截屏2024-02-23 17 32 13

After
截屏2024-02-23 17 31 38

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Covered by existing tests

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-feature this PR introduces a new feature to the codebase label Feb 20, 2024
@Dousir9 Dousir9 requested a review from xudong963 February 23, 2024 09:42
@Dousir9 Dousir9 marked this pull request as ready for review February 23, 2024 09:43
@xudong963 xudong963 added this pull request to the merge queue Feb 26, 2024
Merged via the queue into databendlabs:main with commit 3df638d Feb 26, 2024
79 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants