Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[store] refactor: remove RaftState::write_snapshot_meta(). #1482

Merged
merged 1 commit into from
Aug 16, 2021

Conversation

drmingdrmer
Copy link
Member

@drmingdrmer drmingdrmer commented Aug 16, 2021

I hereby agree to the terms of the CLA available at: https://datafuse.rs/policies/cla/

Summary

[store] refactor: remove RaftState::write_snapshot_meta().

It is a bad idea to work around the problem that state machine does not
save membership config.
Solving the problem where it is introduced saves a lot troubles.
I should not have ever tried.
The better solution is: #1479

Changelog

  • Improvement

Related Issues

It is a bad idea to work around the problem that state machine does not
save membership config.
Solving the problem where it is introduce saves a lot trouble.
I should not have ever tried.
The better solution is: databendlabs#1479
@drmingdrmer drmingdrmer added this to the v0.5 milestone Aug 16, 2021
@databend-bot
Copy link
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

2 similar comments
@databend-bot
Copy link
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@databend-bot
Copy link
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@drmingdrmer drmingdrmer marked this pull request as ready for review August 16, 2021 17:33
@codecov-commenter
Copy link

Codecov Report

Merging #1482 (9b08859) into master (b6ba0b3) will decrease coverage by 0%.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1482   +/-   ##
======================================
- Coverage      73%     73%   -1%     
======================================
  Files         506     506           
  Lines       29987   29924   -63     
======================================
- Hits        21931   21869   -62     
+ Misses       8056    8055    -1     
Impacted Files Coverage Δ
store/src/meta_service/raft_state.rs 90% <ø> (-2%) ⬇️
store/src/meta_service/raft_state_kv.rs 64% <ø> (-2%) ⬇️
store/src/meta_service/raft_state_test.rs 98% <ø> (+1%) ⬆️
query/src/api/http/v1/cluster.rs 83% <0%> (-4%) ⬇️
store/src/meta_service/network.rs 46% <0%> (-2%) ⬇️
store/src/meta_service/raftmeta.rs 78% <0%> (-1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6ba0b3...9b08859. Read the comment docs.

@databend-bot
Copy link
Member

CI Passed
Reviewer Approved
Let's Merge

@databend-bot databend-bot merged commit d153675 into databendlabs:master Aug 16, 2021
@drmingdrmer drmingdrmer deleted the rm-snap-meta branch August 16, 2021 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants