Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[functions] add windowFunnel function #1519

Merged
merged 9 commits into from
Aug 21, 2021
Merged

Conversation

sundy-li
Copy link
Member

I hereby agree to the terms of the CLA available at: https://datafuse.rs/policies/cla/

Summary

[functions] add windowFunnel function

Changelog

  • New Feature

Related Issues

Fixes #966

Test Plan

Unit Tests

Stateless Tests

@databend-bot
Copy link
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@databend-bot databend-bot added the pr-feature this PR introduces a new feature to the codebase label Aug 19, 2021
@codecov-commenter
Copy link

codecov-commenter commented Aug 19, 2021

Codecov Report

Merging #1519 (09dbf8b) into master (d127324) will decrease coverage by 0%.
The diff coverage is 35%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #1519    +/-   ##
=======================================
- Coverage      73%     73%    -1%     
=======================================
  Files         528     529     +1     
  Lines       32266   32558   +292     
=======================================
+ Hits        23784   23862    +78     
- Misses       8482    8696   +214     
Impacted Files Coverage Δ
common/datavalues/src/data_value.rs 39% <ø> (ø)
common/datavalues/src/data_value_ops.rs 40% <0%> (-8%) ⬇️
.../functions/src/aggregates/aggregate_arg_min_max.rs 37% <ø> (ø)
common/functions/src/aggregates/aggregate_avg.rs 91% <ø> (ø)
common/functions/src/aggregates/aggregate_count.rs 67% <ø> (ø)
...mmon/functions/src/aggregates/aggregate_min_max.rs 44% <ø> (ø)
common/functions/src/aggregates/aggregate_sum.rs 87% <ø> (ø)
...unctions/src/aggregates/aggregate_window_funnel.rs 0% <0%> (ø)
...mmon/functions/src/aggregates/aggregator_common.rs 61% <0%> (-20%) ⬇️
common/planners/src/plan_expression_action.rs 27% <0%> (-4%) ⬇️
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d127324...09dbf8b. Read the comment docs.

@sundy-li sundy-li requested review from zhang2014 and BohuTANG August 20, 2021 09:00
@sundy-li sundy-li marked this pull request as ready for review August 20, 2021 09:00
@sundy-li
Copy link
Member Author

@@ -231,6 +231,7 @@ macro_rules! creator {

pub fn try_create_aggregate_avg_function(
display_name: &str,
_params: Vec<DataValue>,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

params are constant?

Copy link
Member

@zhang2014 zhang2014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@databend-bot
Copy link
Member

CI Passed
Reviewer Approved
Let's Merge

2 similar comments
@databend-bot
Copy link
Member

CI Passed
Reviewer Approved
Let's Merge

@databend-bot
Copy link
Member

CI Passed
Reviewer Approved
Let's Merge

@zhang2014 zhang2014 merged commit 8e885e1 into databendlabs:master Aug 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[functions] window funnel function
5 participants