-
Notifications
You must be signed in to change notification settings - Fork 756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[functions] add windowFunnel function #1519
Conversation
Thanks for the contribution! Please review the labels and make any necessary changes. |
Codecov Report
@@ Coverage Diff @@
## master #1519 +/- ##
=======================================
- Coverage 73% 73% -1%
=======================================
Files 528 529 +1
Lines 32266 32558 +292
=======================================
+ Hits 23784 23862 +78
- Misses 8482 8696 +214
Continue to review full report at Codecov.
|
@@ -231,6 +231,7 @@ macro_rules! creator { | |||
|
|||
pub fn try_create_aggregate_avg_function( | |||
display_name: &str, | |||
_params: Vec<DataValue>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
params are constant?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
CI Passed |
2 similar comments
CI Passed |
CI Passed |
I hereby agree to the terms of the CLA available at: https://datafuse.rs/policies/cla/
Summary
[functions] add windowFunnel function
Changelog
Related Issues
Fixes #966
Test Plan
Unit Tests
Stateless Tests