Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(query): support alter table comment #15227

Merged
merged 1 commit into from
Apr 13, 2024
Merged

Conversation

TCeason
Copy link
Collaborator

@TCeason TCeason commented Apr 12, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

Support change table comment

alter table T comment='just demo';

Note:

This pr add a new plan ModifyTableCommentPlan, and in privilege access, user that at least has table's alter privilege can execute alter table commnt.

Tests

  • Unit Test
  • Logic Test

Type of change

  • New Feature (non-breaking change which adds functionality)

This change is Reviewable

@github-actions github-actions bot added the pr-feature this PR introduces a new feature to the codebase label Apr 12, 2024
@TCeason TCeason requested a review from andylokandy April 12, 2024 23:45
@TCeason
Copy link
Collaborator Author

TCeason commented Apr 12, 2024

cc wait @andylokandy review

@sundy-li sundy-li added this pull request to the merge queue Apr 13, 2024
@BohuTANG BohuTANG removed this pull request from the merge queue due to a manual request Apr 13, 2024
@BohuTANG BohuTANG merged commit 6453c48 into databendlabs:main Apr 13, 2024
78 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: alter table need support modify table comment
4 participants