-
Notifications
You must be signed in to change notification settings - Fork 760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
debug print errors #1559
debug print errors #1559
Conversation
Thanks for the contribution! Please review the labels and make any necessary changes. |
1 similar comment
Thanks for the contribution! Please review the labels and make any necessary changes. |
- Every test case creates its own span as a root. This way the logging/tracing belonging to a single test is easy to grep. - Upgrade to async-raft 0.6.2-alpha.11, with enhanced tracing: a span is send along with a message through channels. Thus a complete workflow can be tracked.
When running unittest, with heavy cpu load, heartbeat message has chance to be delayed too much. When this happens, a follower tries to elect itself and revert the current leader to a follower state. This causes the leader to discard every in progress request it has received. And the client receives an **inappropriate** error `RaftError::Shuttingdown`. This is actually not a bug. In such case in practise, a client should re-fetch the latest leader and retry. For a unittest, we just extend the timeout to let tests pass happily, even on a poor CI VM.
…trace when converting anyhow::Error to ErrorCode
Codecov Report
@@ Coverage Diff @@
## master #1559 +/- ##
=======================================
Coverage 73% 73%
=======================================
Files 535 535
Lines 32862 32997 +135
=======================================
+ Hits 24076 24308 +232
+ Misses 8786 8689 -97
Continue to review full report at Codecov.
|
Just for test. Closed |
I hereby agree to the terms of the CLA available at: https://datafuse.rs/policies/cla/
Summary
debug print errors
add log of error for install_snapshot
add more logs to sled tree get
[store] fix: fix flaky test: generic-kv: get-unexpired
[store] refactor: remove span for tree.flush(), record source an backtrace when converting anyhow::Error to ErrorCode
[ci] on failure of test, upload the log and state data file for debugging
[store] refactor: refine tracing log
[test]: refactor: run unittest with RUST_BACKTRACE=full
[store] refactor: elaborate error log
[query] fix dep revision
[store] test: fix the RaftError::Shutdown issue
When running unittest, with heavy cpu load, heartbeat message has chance
to be delayed too much.
When this happens, a follower tries to elect itself and revert the
current leader to a follower state.
This causes the leader to discard every in progress request it has
received. And the client receives an inappropriate error
RaftError::Shuttingdown
.This is actually not a bug.
In such case in practise, a client should re-fetch the latest leader
and retry.
For a unittest, we just extend the timeout to let tests pass happily,
even on a poor CI VM.
[store] refactor: refine tracing
Every test case creates its own span as a root.
This way the logging/tracing belonging to a single test is easy to
grep.
Upgrade to async-raft 0.6.2-alpha.11, with enhanced tracing:
a span is send along with a message through channels.
Thus a complete workflow can be tracked.
Changelog
Bug Fix
Improvement
Build/Testing/CI
Related Issues