-
Notifications
You must be signed in to change notification settings - Fork 760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(query): refactor hash join spill #15746
Conversation
Docker Image for PR
|
Docker Image for PR
|
Docker Image for PR
|
Docker Image for PR
|
Docker Image for PR
|
src/query/service/src/pipelines/processors/transforms/hash_join/hash_join_build_state.rs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
Code readability and maintainability
SyncStep
,AsyncStep
, andFinish
, ensuring that step transition occurs in the event and this PR redesigns step transition to make the step transition logic clearer and improve code readability and maintainability.ProbeSpillHandler
andBuildSpillHandler
toHashJoinSpiller
to improve code maintainability.HashTableType
to reduce code.Bug Fixed
Tests
Performance (Databend Cloud XSMALL)
TPC-H SF100 Q18: 164s → 137s
Test script:
Tests
Type of change
This change is