Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(query): decimal div overflow #15856

Merged
merged 3 commits into from
Jun 22, 2024
Merged

fix(query): decimal div overflow #15856

merged 3 commits into from
Jun 22, 2024

Conversation

sundy-li
Copy link
Member

@sundy-li sundy-li commented Jun 21, 2024 •
edited by drmingdrmer
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

fix(query): decimal div overflow

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-bugfix this PR patches a bug in codebase label Jun 21, 2024
@BohuTANG BohuTANG merged commit b256d3d into databendlabs:main Jun 22, 2024
73 checks passed
yufan022 pushed a commit to yufan022/databend that referenced this pull request Jun 24, 2024
@sundy-li @yufan022
fix(query): decimal div overflow (databendlabs#15856)
61f7fb6 
* fix(query): decimal div overflow

* fix(query): decimal div overflow

* fix(query): decimal div overflow

(cherry picked from commit b256d3d)
@andylokandy andylokandy mentioned this pull request Oct 25, 2024
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@b41sh b41sh b41sh approved these changes

@youngsofun youngsofun Awaiting requested review from youngsofun

Assignees
No one assigned
Labels
pr-bugfix this PR patches a bug in codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: Incorrect decimal division result
3 participants
@sundy-li @b41sh @BohuTANG