refactor: Migrate catalog info into table info #15857
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
This PR will migrate catalog info into table info.
We previously stored
catalog_name: String
inTableMeta
, which persisted in metasrv. However, this design was flawed as we only have a single catalog nameddefault
in each metasrv instance.This PR removed
catalog_name
inTableMeta
, instead, addcatalog_info: Arc<CatalogInfo>
inTableInfo
. This change makes existing code to work as before and make it much easier for external catalog to implement.For example, it's a strong requirement to allowing build a table from
TableInfo
. In the fast, we have to store catalog related information in table options or engine options. But now, we can useCatalogInfo
directly without extra work.This PR removes all blockers of migrating to iceberg-rust, part of #15809
Tests
Type of change
This change is