Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(geo): add geography data type #16286

Merged
merged 7 commits into from
Aug 21, 2024
Merged

Conversation

forsaken628
Copy link
Collaborator

@forsaken628 forsaken628 commented Aug 20, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

add geography data type

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

Signed-off-by: coldWater <forsaken628@gmail.com>
Signed-off-by: coldWater <forsaken628@gmail.com>
@github-actions github-actions bot added the pr-feature this PR introduces a new feature to the codebase label Aug 20, 2024
Signed-off-by: coldWater <forsaken628@gmail.com>
Signed-off-by: coldWater <forsaken628@gmail.com>
Copy link
Member

@drmingdrmer drmingdrmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just reviewed the meta-data part, looks great. Other pieces are left unreviewed.

Reviewed 6 of 54 files at r1.
Reviewable status: 6 of 56 files reviewed, 4 unresolved discussions (waiting on @b41sh, @forsaken628, and @sundy-li)

@BohuTANG BohuTANG merged commit 1d211ec into databendlabs:main Aug 21, 2024
69 of 70 checks passed
@forsaken628 forsaken628 deleted the geog3 branch August 21, 2024 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants