Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(query): add config udf_server_allow_insecure #16290

Merged
merged 2 commits into from
Aug 20, 2024

Conversation

everpcpc
Copy link
Member

@everpcpc everpcpc commented Aug 20, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

Since we are only verifying host & port in allow_list, insecure server should not be enabled by default.

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-feature this PR introduces a new feature to the codebase label Aug 20, 2024
@everpcpc everpcpc marked this pull request as ready for review August 20, 2024 07:31
@everpcpc everpcpc requested a review from sundy-li August 20, 2024 07:31
@everpcpc everpcpc merged commit fe54569 into databendlabs:main Aug 20, 2024
72 checks passed
@everpcpc everpcpc deleted the fix-udf branch August 20, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants