Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(query): add setting enable_upgrade_meta_data_to_pb #16305

Closed
wants to merge 2 commits into from

Conversation

TCeason
Copy link
Collaborator

@TCeason TCeason commented Aug 21, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

enable_upgrade_meta_data_to_pb default disable.

Old version upgrade to new version, not auto upgrade json to pb.

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-refactor this PR changes the code base without new features or bugfix label Aug 21, 2024
enable_upgrade_meta_data_to_pb default disable.

Old version upgrade to new version, not auto upgrade json to pb.
Copy link
Member

@drmingdrmer drmingdrmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't enable_upgrade_meta_data_to_pb an field of RoleMgr? When creating aRoleMgr, set this field and it does not need to pass in this flag to every RoleMgr method. Unless I missed something?

Reviewed 2 of 38 files at r1, all commit messages.
Reviewable status: 2 of 38 files reviewed, all discussions resolved (waiting on @BohuTANG, @dantengsky, and @flaneur2020)

@TCeason TCeason marked this pull request as draft August 21, 2024 15:24
@TCeason
Copy link
Collaborator Author

TCeason commented Aug 22, 2024

use #16306

@TCeason TCeason closed this Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-refactor this PR changes the code base without new features or bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants