Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: kv-app-errors does not need serde #16324

Merged

Conversation

drmingdrmer
Copy link
Member

@drmingdrmer drmingdrmer commented Aug 23, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

refactor: kv-app-errors does not need serde

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Refactoring

Related Issues


This change is Reviewable

@drmingdrmer drmingdrmer marked this pull request as ready for review August 23, 2024 16:13
@github-actions github-actions bot added the pr-refactor this PR changes the code base without new features or bugfix label Aug 23, 2024
@drmingdrmer drmingdrmer force-pushed the 119-remove-serde-from-kv-app-err branch from 7329d8f to eb01693 Compare August 24, 2024 03:26
@drmingdrmer drmingdrmer merged commit 16c04a1 into databendlabs:main Aug 24, 2024
69 checks passed
@drmingdrmer drmingdrmer deleted the 119-remove-serde-from-kv-app-err branch August 24, 2024 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-refactor this PR changes the code base without new features or bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant