Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(query): fix column leaf_index #16537

Merged
merged 9 commits into from
Sep 28, 2024
Merged

fix(query): fix column leaf_index #16537

merged 9 commits into from
Sep 28, 2024

Conversation

Dousir9
Copy link
Member

@Dousir9 Dousir9 commented Sep 27, 2024 •
edited by drmingdrmer
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

Use column id as column leaf_index.

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Sep 27, 2024
@Dousir9 Dousir9 marked this pull request as ready for review September 27, 2024 15:39
@Dousir9 Dousir9 marked this pull request as draft September 27, 2024 17:20
@Dousir9 Dousir9 marked this pull request as ready for review September 28, 2024 02:09
@sundy-li sundy-li changed the title chore(query): fix column leaf_index fix(query): fix column leaf_index Sep 28, 2024
@github-actions github-actions bot added the pr-bugfix this PR patches a bug in codebase label Sep 28, 2024
@Dousir9 Dousir9 added this pull request to the merge queue Sep 28, 2024
@BohuTANG BohuTANG removed this pull request from the merge queue due to a manual request Sep 28, 2024
@BohuTANG BohuTANG merged commit 0189b01 into databendlabs:main Sep 28, 2024
74 checks passed
@andylokandy andylokandy mentioned this pull request Oct 15, 2024
Merged
11 tasks
@andylokandy andylokandy mentioned this pull request Oct 25, 2024
Merged
11 tasks
dantengsky pushed a commit that referenced this pull request Oct 29, 2024
@Dousir9 @dantengsky
fix(query): fix column leaf_index (#16537)
fd4b046 
* chore(query): fix column leaf_index

* chore(test): update sqllogictest

* chore(binder): refine code

* chore(binder): fix tuple inner_field

* chore(binder): fix tuple inner column_id

* chore(test): update test

* chore(binder): fix TUPLE inner_column_id

* chore(test): update sqllogictest

* chore(test): update sqllogictest
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xudong963 xudong963 xudong963 approved these changes

@sundy-li sundy-li sundy-li approved these changes

@b41sh b41sh b41sh approved these changes

Assignees
No one assigned
Labels
pr-bugfix this PR patches a bug in codebase pr-chore this PR only has small changes that no need to record, like coding styles.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Dousir9 @b41sh @sundy-li @xudong963 @BohuTANG