Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Remove not used async-std #16745

Merged
merged 7 commits into from
Nov 1, 2024
Merged

refactor: Remove not used async-std #16745

merged 7 commits into from
Nov 1, 2024

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Oct 31, 2024 •
edited
Loading

Signed-off-by: Xuanwo github@xuanwo.io

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

async-std is depended by arrow's tests, but we never use this feature, just remove.

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

Xuanwo added 6 commits October 31, 2024 17:34
@Xuanwo
refactor: Enforce all deps must be declared at root
eec4c60 
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo
Add docs
757a724 
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo
Merge branch 'main' into enforce-rule
2788d40
@Xuanwo
sort deps
2bea80c 
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo
Save work
30d6677 
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo
Merge remote-tracking branch 'origin/main' into remove-async-std
392089e 
Signed-off-by: Xuanwo <github@xuanwo.io>
@github-actions github-actions bot added the pr-refactor this PR changes the code base without new features or bugfix label Oct 31, 2024
@Xuanwo Xuanwo requested a review from sundy-li October 31, 2024 17:18
@Xuanwo Xuanwo changed the title refactor: Enforce all deps must be declared at root refactor: Remove not used async-std Oct 31, 2024
@Xuanwo
format toml
5f83efb 
Signed-off-by: Xuanwo <github@xuanwo.io>
@sundy-li sundy-li added this pull request to the merge queue Nov 1, 2024
@sundy-li
Copy link
Member

sundy-li commented Nov 1, 2024

cargo machete did not lint this?

Merged via the queue into databendlabs:main with commit 62c7299 Nov 1, 2024
72 checks passed
@Xuanwo
Copy link
Member Author

Xuanwo commented Nov 1, 2024

cargo machete did not lint this?

Used by common/arrow's tests.

@Xuanwo Xuanwo deleted the remove-async-std branch November 1, 2024 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sundy-li sundy-li sundy-li approved these changes

Assignees
No one assigned
Labels
pr-refactor this PR changes the code base without new features or bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Xuanwo @sundy-li