refactor: remove EmbeddedMeta #16847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drmingdrmer
changed the title
github-actions
bot
added
the
pr-refactor
drmingdrmer
force-pushed
the
167-refactor-sm
branch
2 times, most recently
from
e17fc83 to
f42d801
Compare
drmingdrmer
force-pushed
the
167-refactor-sm
branch
from
cf3c6bf to
1c3f46f
Compare
sundy-li
approved these changes
Nov 15, 2024
drmingdrmer
force-pushed
the
167-refactor-sm
branch
from
1c3f46f to
01ffe99
Compare
EmbeddedMeta is no longer used and should be removed. Replace EmbeddedMeta with InMemoryMeta which is design for testing purpose only.
drmingdrmer
force-pushed
the
167-refactor-sm
branch
from
01ffe99 to
49eb387
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
refactor: remove EmbeddedMeta
EmbeddedMeta is no longer used and should be removed.
Replace EmbeddedMeta with MemMeta which is design for testing
purpose only.
Tests
Type of change
Related Issues
This change is