Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storge): write progress in compact hook #16901

Merged
merged 2 commits into from
Nov 21, 2024

Conversation

zhyass
Copy link
Member

@zhyass zhyass commented Nov 21, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

This PR fixes an issue where the write progress could become inconsistent when compaction was triggered after a write. Previously, compaction failures would cause an early return, skipping the reset of write progress and resulting in incorrect output.
After the fix, the write progress will consistently reflect the result of the write operation, regardless of whether the compaction succeeds or fails.

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-bugfix this PR patches a bug in codebase label Nov 21, 2024
@dantengsky dantengsky added this pull request to the merge queue Nov 21, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 21, 2024
@zhyass zhyass enabled auto-merge November 21, 2024 10:54
@zhyass zhyass added this pull request to the merge queue Nov 21, 2024
Merged via the queue into databendlabs:main with commit d38c91c Nov 21, 2024
72 checks passed
@zhyass zhyass deleted the feat_stream branch November 21, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix this PR patches a bug in codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants