Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(storage): hook compact avoid scan all segments #16954

Merged
merged 1 commit into from
Nov 27, 2024
Merged

chore(storage): hook compact avoid scan all segments #16954

merged 1 commit into from
Nov 27, 2024

Conversation

zhyass
Copy link
Member

@zhyass zhyass commented Nov 27, 2024 •
edited by drmingdrmer
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

To avoid traversing all segments, the compact block operation will process only the first limit segments if a limit is specified.

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@zhyass zhyass requested a review from dantengsky November 27, 2024 04:45
@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Nov 27, 2024
@dantengsky dantengsky added this pull request to the merge queue Nov 27, 2024
Merged via the queue into databendlabs:main with commit b6ff044 Nov 27, 2024
72 checks passed
dantengsky pushed a commit to dantengsky/fuse-query that referenced this pull request Jan 11, 2025
@zhyass @dantengsky
chore(storage): hook compact avoid scan all segments (databendlabs#16954
8508642 
)
@dantengsky dantengsky mentioned this pull request Jan 11, 2025
Merged
11 tasks
dantengsky added a commit that referenced this pull request Jan 12, 2025
@dantengsky @zhyass
chore: backport tweak compact strategy to 636-rc8.1 (#17246)
fdf4332 
* chore(storage): do compact before recluster during compact hook (#16949)

* chore: do compact before recluster during compact hook

* update

---------

Co-authored-by: dantengsky <dantengsky@gmail.com>

* chore(storage): hook compact avoid scan all segments (#16954)

* tweak gh action setup_bendsql

* fix yml lint

* fix statless tests

* sync stateless tests

---------

Co-authored-by: zhya <mytesla@live.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dantengsky dantengsky dantengsky approved these changes

Assignees
No one assigned
Labels
pr-chore this PR only has small changes that no need to record, like coding styles.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhyass @dantengsky