Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: mget db names and table names remove duplicate ids to avoid too many parameters #17013

Merged
merged 4 commits into from
Dec 9, 2024

Conversation

b41sh
Copy link
Member

@b41sh b41sh commented Dec 7, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

refactor call mget_database_names_by_ids and mget_table_names_by_ids remove duplicate ids to avoid too many parameters.
fix reorder of the returned names, the order of the returned names are same as the parameter id.

  • fixes: #[Link the issue here]

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@b41sh b41sh requested a review from TCeason December 7, 2024 07:05
@github-actions github-actions bot added the pr-refactor this PR changes the code base without new features or bugfix label Dec 7, 2024
@b41sh b41sh marked this pull request as draft December 7, 2024 07:43
@b41sh b41sh marked this pull request as ready for review December 8, 2024 04:34
@TCeason TCeason added this pull request to the merge queue Dec 9, 2024
@BohuTANG BohuTANG removed this pull request from the merge queue due to a manual request Dec 9, 2024
@BohuTANG BohuTANG merged commit 9700a3b into databendlabs:main Dec 9, 2024
78 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-refactor this PR changes the code base without new features or bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants