Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(query): fix join on not null column cause panic #17069

Merged
merged 5 commits into from
Dec 19, 2024

Conversation

b41sh
Copy link
Member

@b41sh b41sh commented Dec 17, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

bind join left and right column wrap nullable will cause not null column have a nullable data type, and evaluator checks the data type of the column data when it is executed. If the data type does not match, the check fails and panic occurs. After the modification, add additional EvalScalar plan to generate derived nullable columns if join operator need.

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@b41sh b41sh requested review from sundy-li and xudong963 December 17, 2024 15:20
@github-actions github-actions bot added the pr-bugfix this PR patches a bug in codebase label Dec 17, 2024
@b41sh b41sh marked this pull request as ready for review December 19, 2024 00:48
@b41sh b41sh added this pull request to the merge queue Dec 19, 2024
Merged via the queue into databendlabs:main with commit 3b7470f Dec 19, 2024
75 checks passed
@b41sh b41sh deleted the fix-join-on branch December 19, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix this PR patches a bug in codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: join on not null column case panic
2 participants