Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check if the table option is valid according to the engine #17076

Merged
merged 2 commits into from
Dec 19, 2024

Conversation

SkyFan2002
Copy link
Member

@SkyFan2002 SkyFan2002 commented Dec 18, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

  1. Check if the table option is valid according to the engine. For example, for the Fuse engine, both location and seed are invalid options.
  2. When using SHOW CREATE TABLE, the external location for the Fuse engine will no longer be displayed as "LOCATION = ", to distinguish it from the table option location.

Close #17075.

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-bugfix this PR patches a bug in codebase label Dec 18, 2024
@SkyFan2002 SkyFan2002 marked this pull request as ready for review December 19, 2024 05:09
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Xuanwo Xuanwo added this pull request to the merge queue Dec 19, 2024
@BohuTANG BohuTANG removed this pull request from the merge queue due to a manual request Dec 19, 2024
@BohuTANG BohuTANG merged commit 19012a5 into databendlabs:main Dec 19, 2024
78 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix this PR patches a bug in codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: LOCATION of CREATE TABLE does NOT work as expected
3 participants