Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(query): fix thread leak #17077

Merged
merged 3 commits into from
Dec 19, 2024
Merged

fix(query): fix thread leak #17077

merged 3 commits into from
Dec 19, 2024

Conversation

zhang2014
Copy link
Member

@zhang2014 zhang2014 commented Dec 18, 2024 •
edited by drmingdrmer
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

fix(query): fix thread leak

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - try add test in next pr CC: @dqhl76

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-bugfix this PR patches a bug in codebase label Dec 18, 2024
dqhl76
dqhl76 approved these changes Dec 18, 2024
View reviewed changes
Copy link
Collaborator

@dqhl76 dqhl76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will add more tests in next PR

@zhang2014 zhang2014 enabled auto-merge December 19, 2024 01:34
@zhang2014 zhang2014 added this pull request to the merge queue Dec 19, 2024
@BohuTANG BohuTANG removed this pull request from the merge queue due to a manual request Dec 19, 2024
@BohuTANG BohuTANG merged commit e131edf into databendlabs:main Dec 19, 2024
72 checks passed
@dantengsky dantengsky mentioned this pull request Dec 19, 2024
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dqhl76 dqhl76 dqhl76 approved these changes

@youngsofun youngsofun youngsofun approved these changes

Assignees
No one assigned
Labels
pr-bugfix this PR patches a bug in codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zhang2014 @youngsofun @dqhl76 @BohuTANG