-
Notifications
You must be signed in to change notification settings - Fork 755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(query): Disabled the shrink_scalar optimization for cast expressions during the resolve procedure args #17119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TCeason
force-pushed
the
procedure_no_shrink_arg
branch
from
December 26, 2024 03:27
d7eba73
to
3f2f29d
Compare
try fix this with modify of
|
TCeason
force-pushed
the
procedure_no_shrink_arg
branch
from
December 26, 2024 03:40
3f2f29d
to
ac85fb8
Compare
Using this PR as a benchmark check (unrelated to PR changes). |
Docker Image for PR
|
sundy-li
reviewed
Dec 26, 2024
TCeason
force-pushed
the
procedure_no_shrink_arg
branch
from
December 26, 2024 10:13
ac85fb8
to
a808187
Compare
sundy-li
added
ci-benchmark-cloud
Benchmark: run only cloud tests for tpch/hits
and removed
ci-benchmark
Benchmark: run all test
labels
Dec 27, 2024
Docker Image for PR
|
sundy-li
approved these changes
Dec 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ci-benchmark-cloud
Benchmark: run only cloud tests for tpch/hits
pr-bugfix
this PR patches a bug in codebase
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
Explicit casts might be present to ensure the type of a procedure parameter conforms to an expected type. Simplifying these away might lead to procedure call failures.
Tests
Type of change
This change is