Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(query): improve hook vacuum temp after query #17125

Merged
merged 5 commits into from
Dec 27, 2024
Merged

chore(query): improve hook vacuum temp after query #17125

merged 5 commits into from
Dec 27, 2024

Conversation

sundy-li
Copy link
Member

@sundy-li sundy-li commented Dec 26, 2024 •
edited
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

chore(query): improve hook vacuum temp after query

  1. fetch spill meta files on parallel
  2. exchange send/recv spill nums in progress info

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@sundy-li sundy-li added the ci-benchmark-cloud Benchmark: run only cloud tests for tpch/hits label Dec 26, 2024
@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Dec 26, 2024
@github-actions GitHub Actions
Copy link
Contributor

Docker Image for PR

  • tag: pr-17125-264847b-1735212519

note: this image tag is only available for internal use,
please check the internal doc for more details.

@github-actions GitHub Actions
Copy link
Contributor

ClickBench Report

@databendlabs databendlabs deleted a comment from github-actions bot Dec 26, 2024
@sundy-li sundy-li marked this pull request as draft December 26, 2024 14:43
@sundy-li sundy-li added ci-benchmark-cloud Benchmark: run only cloud tests for tpch/hits and removed ci-benchmark-cloud Benchmark: run only cloud tests for tpch/hits labels Dec 26, 2024
@github-actions GitHub Actions
Copy link
Contributor

Docker Image for PR

  • tag: pr-17125-219061f-1735231189

note: this image tag is only available for internal use,
please check the internal doc for more details.

@github-actions GitHub Actions
Copy link
Contributor

ClickBench Report

@sundy-li sundy-li changed the title chore(query): improve unload_spill_meta lock chore(query): improve hook vacuum temp after query Dec 27, 2024
@sundy-li sundy-li requested a review from zhang2014 December 27, 2024 01:51
@sundy-li sundy-li marked this pull request as ready for review December 27, 2024 01:51
@sundy-li sundy-li requested a review from Xuanwo December 27, 2024 01:51
@BohuTANG BohuTANG merged commit 9a8784e into databendlabs:main Dec 27, 2024
78 checks passed
@sundy-li sundy-li mentioned this pull request Dec 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhang2014 zhang2014 zhang2014 approved these changes

@Xuanwo Xuanwo Xuanwo approved these changes

Assignees
No one assigned
Labels
ci-benchmark-cloud Benchmark: run only cloud tests for tpch/hits pr-chore this PR only has small changes that no need to record, like coding styles.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sundy-li @Xuanwo @zhang2014 @BohuTANG