Skip to content

fix(query): fix cast nested types cause panic #17622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 19, 2025

Conversation

b41sh
Copy link
Member

@b41sh b41sh commented Mar 18, 2025

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

ArrayColumn only intercepts offsets when executing the slice function without modifying the underlying values, resulting in a panic when the length of the values is not matched with the offsets when using values directly. this PR changes the fields values and offsets of ArrayColumn from public to private, the values inside ArrayColumn can be used by calling underlying_column and underlying_offsets to avoid getting incorrect values.

By the way, the set variable syntax has been changed to allow query with parenthesis to be executed correctly.

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@b41sh b41sh requested review from sundy-li and TCeason March 18, 2025 08:52
@github-actions github-actions bot added the pr-bugfix this PR patches a bug in codebase label Mar 18, 2025
@b41sh b41sh merged commit d9a2145 into databendlabs:main Mar 19, 2025
76 checks passed
loloxwg pushed a commit to loloxwg/databend that referenced this pull request Apr 3, 2025
* fix(query): fix cast nested types cause panic

* fix

* fix typo

* fix

* fix

* fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix this PR patches a bug in codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: cast nested type cause panic
3 participants