fix(query): fix cast nested types cause panic #17622
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
ArrayColumn
only intercepts offsets when executing the slice function without modifying the underlying values, resulting in a panic when the length of the values is not matched with the offsets when using values directly. this PR changes the fields values and offsets ofArrayColumn
from public to private, the values insideArrayColumn
can be used by callingunderlying_column
andunderlying_offsets
to avoid getting incorrect values.By the way, the
set variable
syntax has been changed to allow query with parenthesis to be executed correctly.Tests
Type of change
This change is