Skip to content

fix: persistent log table may loss records when shutdown #17695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 3, 2025

Conversation

dqhl76
Copy link
Collaborator

@dqhl76 dqhl76 commented Apr 3, 2025

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

follow up: #17598

Add force collect to fix log data loss.

root@localhost:8000/default> select * from persistent_system.query_log order by timestamp desc limit 1;
-[ RECORD 1 ]-----------------------------------
   timestamp: 2025-04-02 13:11:22.354154
        path: databend_query::entry: entry.rs:426
      target: databend_query::entry
   log_level: INFO
  cluster_id: test_cluster
     node_id: TR5fixys6tAWEot24JEZ61
warehouse_id: NULL
    query_id: NULL
     message: Shutdown server.
      fields: {}

1 row read in 0.097 sec. Processed 705 row, 5.59 KiB (7.26 thousand row/s, 57.62 KiB/s)

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Last PR covered

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-bugfix this PR patches a bug in codebase label Apr 3, 2025
@dqhl76 dqhl76 marked this pull request as ready for review April 3, 2025 03:02
@dqhl76 dqhl76 requested a review from zhang2014 April 3, 2025 03:02
@zhang2014 zhang2014 merged commit e0a6e5a into databendlabs:main Apr 3, 2025
166 of 172 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix this PR patches a bug in codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants