-
Notifications
You must be signed in to change notification settings - Fork 770
feat(query): support cluster level concurrent limit #17778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 4 files at r1, 8 of 8 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @zhang2014)
src/query/service/src/sessions/queue_mgr.rs
line 238 at r2 (raw file):
unsafe impl Send for AcquireQueueGuard {} unsafe impl Sync for AcquireQueueGuard {}
It's not safe to impl Sync for it. It may lead to a panic.
The HTTP handler needs it. Though I'm not sure why. But it's safe here. |
wait #17783 |
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
feat(query): support cluster level concurrent limit
Tests
Type of change
This change is