Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[store] refactor: SledTree::open need not to be async #1796

Merged
merged 1 commit into from
Sep 11, 2021

Conversation

drmingdrmer
Copy link
Member

I hereby agree to the terms of the CLA available at: https://datafuse.rs/policies/cla/

Summary

[store] refactor: SledTree::open need not to be async

Changelog

  • Improvement

Related Issues

@drmingdrmer drmingdrmer added this to the v0.5 milestone Sep 11, 2021
@databend-bot
Copy link
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

1 similar comment
@databend-bot
Copy link
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@databend-bot
Copy link
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

1 similar comment
@databend-bot
Copy link
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@drmingdrmer drmingdrmer marked this pull request as ready for review September 11, 2021 14:10
@PsiACE
Copy link
Member

PsiACE commented Sep 11, 2021

/LGTM

@databend-bot
Copy link
Member

Approved! Thank you for the PR @drmingdrmer

@codecov-commenter
Copy link

codecov-commenter commented Sep 11, 2021

Codecov Report

Merging #1796 (71e0608) into master (607985a) will decrease coverage by 0%.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1796   +/-   ##
======================================
- Coverage      71%     70%   -1%     
======================================
  Files         630     630           
  Lines       37536   37531    -5     
======================================
- Hits        26653   26647    -6     
- Misses      10883   10884    +1     
Impacted Files Coverage Δ
store/src/meta_service/raft_log.rs 91% <100%> (ø)
store/src/meta_service/raft_state.rs 90% <100%> (ø)
store/src/meta_service/sled_tree.rs 94% <100%> (-1%) ⬇️
store/src/meta_service/sled_tree_test.rs 97% <100%> (ø)
store/src/meta_service/state_machine.rs 90% <100%> (ø)
store/src/meta_service/meta_service_impl.rs 75% <0%> (-2%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 607985a...71e0608. Read the comment docs.

@databend-bot
Copy link
Member

CI Passed
Reviewer Approved
Let's Merge

@databend-bot databend-bot merged commit 02185e3 into databendlabs:master Sep 11, 2021
@drmingdrmer drmingdrmer deleted the no-async branch September 11, 2021 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants