ISSUE-1787: add running difference function #1961

ygf11 · 2021-09-25T00:33:43Z

I hereby agree to the terms of the CLA available at: https://databend.rs/policies/cla/

Summary

Add runningDifference function.

Changelog

New Feature

Related Issues

Fixes #1787

Test Plan

Unit Tests

Stateless Tests

databend-bot · 2021-09-25T00:33:46Z

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

codecov-commenter · 2021-09-25T01:07:04Z

Codecov Report

Merging #1961 (594f2f7) into master (c6823b9) will increase coverage by 0%.
The diff coverage is 89%.

@@           Coverage Diff           @@
##           master   #1961    +/-   ##
=======================================
  Coverage      68%     69%            
=======================================
  Files         639     652    +13     
  Lines       36180   36674   +494     
=======================================
+ Hits        24913   25311   +398     
- Misses      11267   11363    +96

Impacted Files	Coverage Δ
common/functions/src/scalars/function_factory.rs	`100% <ø> (ø)`
.../src/scalars/others/running_difference_function.rs	`68% <68%> (ø)`
common/functions/src/scalars/others/other.rs	`85% <85%> (ø)`
...scalars/others/running_difference_function_test.rs	`99% <99%> (ø)`
query/src/configs/config.rs	`50% <0%> (-30%)`	⬇️
common/datavalues/src/arrays/ops/to_values.rs	`9% <0%> (-14%)`	⬇️
query/src/datasources/table/csv/csv_table.rs	`64% <0%> (-12%)`	⬇️
common/datavalues/src/arrays/list/mod.rs	`47% <0%> (-8%)`	⬇️
common/base/src/uniq_id.rs	`93% <0%> (-7%)`	⬇️
query/src/datasources/table/null/null_table.rs	`81% <0%> (-7%)`	⬇️
... and 154 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6823b9...594f2f7. Read the comment docs.

BohuTANG · 2021-09-25T01:53:44Z

/review @sundy-li

databend-bot · 2021-09-25T01:53:46Z

Take the reviewer to sundy-li

BohuTANG · 2021-09-25T02:02:01Z

tests/suites/0_stateless/02_0013_function_running_difference.sql

+insert into runing_difference_test values (1, 1, 1, 'a'),(3, 3, 3, 'b'),(5, 5, 5, 'c'),(10, 10, 10, 'd');
+
+select a, runningDifference(a), b, runningDifference(b), c, runningDifference(c), runningDifference(10) from runing_difference_test;
+select d, runningDifference(d) from runing_difference_test;


Here we can add an error hint to avoid the error info to *.result, like:

select d, runningDifference(d) from runing_difference_test; -- {ErrorCode 7}

sundy-li · 2021-09-25T02:07:03Z

common/functions/src/scalars/others/running_difference_function.rs

+    };
+}
+
+run_difference_compute!(compute_i8, i8, Int16, i16);


What about float numbers?

sundy-li

LGTM, thanks @ygf11

databend-bot · 2021-09-30T08:00:30Z