Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]Add toMonth date function #2042

Merged
merged 2 commits into from
Oct 1, 2021

Conversation

GrapeBaBa
Copy link
Contributor

Signed-off-by: grapebaba 281165273@qq.com

I hereby agree to the terms of the CLA available at: https://databend.rs/policies/cla/

Summary

Add toMonth date function

Changelog

  • New Feature

Related Issues

#853

Fixes #issue

Test Plan

Unit Tests

Stateless Tests

Signed-off-by: grapebaba <281165273@qq.com>
@databend-bot databend-bot added the pr-feature this PR introduces a new feature to the codebase label Oct 1, 2021
@databend-bot
Copy link
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@codecov-commenter
Copy link

codecov-commenter commented Oct 1, 2021

Codecov Report

Merging #2042 (7d707d7) into master (365432c) will increase coverage by 0%.
The diff coverage is 96%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #2042    +/-   ##
=======================================
  Coverage      68%     68%            
=======================================
  Files         650     653     +3     
  Lines       36538   36759   +221     
=======================================
+ Hits        25132   25328   +196     
- Misses      11406   11431    +25     
Impacted Files Coverage Δ
...mon/functions/src/scalars/dates/number_function.rs 52% <60%> (+<1%) ⬆️
common/functions/src/scalars/dates/date.rs 43% <100%> (+<1%) ⬆️
.../functions/src/scalars/dates/date_function_test.rs 98% <100%> (+<1%) ⬆️
dfs/src/api/http_service.rs 14% <0%> (-62%) ⬇️
kvsrv/src/api/http_service.rs 14% <0%> (-62%) ⬇️
dfs/src/api/http_service_test.rs 64% <0%> (-4%) ⬇️
kvsrv/src/api/http_service_test.rs 64% <0%> (-4%) ⬇️
common/kv/src/kv.rs 91% <0%> (-3%) ⬇️
query/src/common/mod.rs 83% <0%> (-3%) ⬇️
common/management/src/namespace/namespace_mgr.rs 70% <0%> (-3%) ⬇️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 365432c...7d707d7. Read the comment docs.

@PsiACE PsiACE requested a review from sundy-li October 1, 2021 14:23
@zhang2014
Copy link
Member

/LGTM @GrapeBaBa Thank you contribution

@databend-bot
Copy link
Member

Approved! Thank you for the PR @GrapeBaBa

@databend-bot
Copy link
Member

CI Passed
Reviewer Approved
Let's Merge

@databend-bot databend-bot merged commit 95e43bf into databendlabs:master Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants