Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USER-2678: Add user privileges [PATCH-1] #2703

Merged
merged 3 commits into from
Nov 8, 2021

Conversation

BohuTANG
Copy link
Member

@BohuTANG BohuTANG commented Nov 8, 2021

I hereby agree to the terms of the CLA available at: https://databend.rs/policies/cla/

Summary

This is the user privileges PATCH-1:

  1. Add user privileges field for userinfo when we create a user, now the privileges is empty.
  2. We have not check the privileges for the users, it should do after User grant privileges #2679

Changelog

  • New Feature

Related Issues

Related #2678

Test Plan

Unit Tests

Stateless Tests

@databend-bot databend-bot added the pr-feature this PR introduces a new feature to the codebase label Nov 8, 2021
@databend-bot
Copy link
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@BohuTANG
Copy link
Member Author

BohuTANG commented Nov 8, 2021

I will merge it with main branch :)

@BohuTANG BohuTANG changed the title USER-2678: Add user privileges USER-2678: Add user privileges [PATCH-1] Nov 8, 2021
@codecov-commenter
Copy link

codecov-commenter commented Nov 8, 2021

Codecov Report

Merging #2703 (157ef1f) into main (e6f840e) will increase coverage by 0%.
The diff coverage is 90%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2703   +/-   ##
=====================================
  Coverage     69%     69%           
=====================================
  Files        616     617    +1     
  Lines      33320   33330   +10     
=====================================
+ Hits       23083   23115   +32     
+ Misses     10237   10215   -22     
Impacted Files Coverage Δ
common/meta/types/src/user_auth.rs 66% <ø> (ø)
common/meta/types/src/user_privilege.rs 66% <66%> (ø)
common/management/src/user/user_api.rs 95% <100%> (+<1%) ⬆️
...rc/datasources/database/system/users_table_test.rs 91% <100%> (+<1%) ⬆️
query/src/interpreters/interpreter_user_create.rs 81% <100%> (-3%) ⬇️
query/src/users/user.rs 70% <100%> (+1%) ⬆️
metasrv/src/meta_service/network.rs 70% <0%> (-1%) ⬇️
metasrv/src/meta_service/meta_service_impl.rs 75% <0%> (+1%) ⬆️
common/management/src/namespace/namespace_mgr.rs 79% <0%> (+1%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6f840e...157ef1f. Read the comment docs.

@databend-bot
Copy link
Member

Wait for another reviewer approval

@BohuTANG BohuTANG merged commit 15c2884 into databendlabs:main Nov 8, 2021
@BohuTANG BohuTANG deleted the dev-user-priv-2678 branch November 8, 2021 11:33
@BohuTANG BohuTANG mentioned this pull request Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need-review pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants