-
Notifications
You must be signed in to change notification settings - Fork 752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fuse table] insert overwrite stmt implementation #3150
[fuse table] insert overwrite stmt implementation #3150
Conversation
Thanks for the contribution! Please review the labels and make any necessary changes. |
This pull request has merge conflicts that must be resolved before it can be merged. @Veeupup please rebase it 🙏 |
We can have both syntaxes. Replace | Insert override . |
are they only different in syntaxes? or any other point I did not get? |
e023c43
to
eb25dd9
Compare
/review @dantengsky |
Take the reviewer to dantengsky |
great work! 👍 It would be better if there were:
|
Codecov Report
@@ Coverage Diff @@
## main #3150 +/- ##
======================================
- Coverage 66% 66% -1%
======================================
Files 673 673
Lines 34965 35464 +499
======================================
+ Hits 23385 23699 +314
- Misses 11580 11765 +185
Continue to review full report at Codecov.
|
: D |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Wait for another reviewer approval |
CI Passed |
I hereby agree to the terms of the CLA available at: https://databend.rs/policies/cla/
Summary
add
insert overwrite
statementChangelog
Related Issues
Fixes #3144
Test Plan
Unit Tests
Stateless Tests