Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dal2: Implement fs support #3695

Merged
merged 4 commits into from
Dec 31, 2021
Merged

dal2: Implement fs support #3695

merged 4 commits into from
Dec 31, 2021

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Dec 29, 2021

Signed-off-by: Xuanwo github@xuanwo.io

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

Part of #3677

Changelog

  • New Feature

Test Plan

Unit Tests

Stateless Tests

Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo Xuanwo requested a review from BohuTANG as a code owner December 29, 2021 10:42
@databend-bot databend-bot added pr-feature this PR introduces a new feature to the codebase labels Dec 29, 2021
@databend-bot
Copy link
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

1 similar comment
@databend-bot
Copy link
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@vercel
Copy link

vercel bot commented Dec 29, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/databend/databend/FHTcRDDi99QDbPPUwB93WnsFinmy
✅ Preview: https://databend-git-fork-xuanwo-dal-fs-databend.vercel.app

Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
@codecov-commenter
Copy link

codecov-commenter commented Dec 29, 2021

Codecov Report

Merging #3695 (0aa382c) into main (8b3dbe1) will increase coverage by 0%.
The diff coverage is 15%.

Impacted file tree graph

@@          Coverage Diff           @@
##            main   #3695    +/-   ##
======================================
  Coverage     59%     60%            
======================================
  Files        705     705            
  Lines      37966   37832   -134     
======================================
- Hits       22761   22757     -4     
+ Misses     15205   15075   -130     
Impacted Files Coverage Δ
common/dal2/src/error.rs 0% <0%> (ø)
common/dal2/src/services/s3.rs 0% <ø> (ø)
common/dal2/src/services/fs.rs 50% <27%> (-50%) ⬇️
metasrv/src/meta_service/raftmeta.rs 47% <0%> (-1%) ⬇️
cli/src/error.rs
common/meta/sled-store/src/sled_tree.rs 91% <0%> (+1%) ⬆️
common/dal/src/accessors/local.rs 86% <0%> (+1%) ⬆️
query/src/storages/fuse/statistics/accumulator.rs 86% <0%> (+1%) ⬆️
common/management/src/cluster/cluster_mgr.rs 80% <0%> (+1%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b3dbe1...0aa382c. Read the comment docs.

@BohuTANG
Copy link
Member

Oops, there are some Conflicting need resolved :/

@Xuanwo
Copy link
Member Author

Xuanwo commented Dec 31, 2021

Oops, there are some Conflicting need resolved :/

I will resolve the conflicting after PR approved.

Ping @dantengsky and @Veeupup to take a look, thanks!

@Veeupup
Copy link
Contributor

Veeupup commented Dec 31, 2021

/LGTM
the code looks very clear!

@databend-bot
Copy link
Member

Wait for another reviewer approval

@BohuTANG BohuTANG merged commit 2bc3328 into databendlabs:main Dec 31, 2021
@Xuanwo Xuanwo deleted the dal-fs branch December 31, 2021 08:23
@dantengsky
Copy link
Member

Ping @dantengsky and @Veeupup to take a look, thanks!
LGTM : )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need-review pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants