Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix httphandler async query. #4304

Merged
merged 3 commits into from
Mar 3, 2022
Merged

fix httphandler async query. #4304

merged 3 commits into from
Mar 3, 2022

Conversation

youngsofun
Copy link
Member

@youngsofun youngsofun commented Mar 2, 2022

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

request blocked because the interpreter is called in handler task. move it to the spawned task.
it works for select which get a stream immediately and the caller wait on it.
but errors show up for queries like COPY, which return a useless stream after real work is done. cc @ZhiHanZ

Changelog

Related Issues

Fix #4297

Test Plan

Unit Tests

Stateless Tests

long copy tested on my mac

@vercel
Copy link

vercel bot commented Mar 2, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/databend/databend/9z74pnDY1LtxMMynRUXKY1Zp5xVi
✅ Preview: Canceled

[Deployment for 2722bc6 canceled]

@mergify
Copy link
Contributor

mergify bot commented Mar 2, 2022

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@Xuanwo
Copy link
Member

Xuanwo commented Mar 3, 2022

Convert to ready for review so that this PR can get merged.

@youngsofun
Copy link
Member Author

@Xuanwo thank you, some tests failed in CI (succeed on my mac), still debugging

@youngsofun youngsofun marked this pull request as ready for review March 3, 2022 06:58
@mergify mergify bot merged commit c9e9360 into databendlabs:main Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: async COPY command support for http handler
5 participants