-
Notifications
You must be signed in to change notification settings - Fork 753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix httphandler async query. #4304
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/databend/databend/9z74pnDY1LtxMMynRUXKY1Zp5xVi [Deployment for 2722bc6 canceled] |
Thanks for the contribution! Please review the labels and make any necessary changes. |
Convert to |
@Xuanwo thank you, some tests failed in CI (succeed on my mac), still debugging |
I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/
Summary
request blocked because the interpreter is called in handler task. move it to the spawned task.
it works for select which get a stream immediately and the caller wait on it.
but errors show up for queries like COPY, which return a useless stream after real work is done. cc @ZhiHanZ
Changelog
Related Issues
Fix #4297
Test Plan
Unit Tests
Stateless Tests
long copy tested on my mac