Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: support REGEXP_SUBSTR function #4771

Merged
merged 3 commits into from
Apr 9, 2022
Merged

feature: support REGEXP_SUBSTR function #4771

merged 3 commits into from
Apr 9, 2022

Conversation

nange
Copy link
Contributor

@nange nange commented Apr 9, 2022

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

  • Support REGEXP_SUBSTR function
  • Fix the multi-byte character index bug of REGEXP_INSTR function

Changelog

  • New Feature
  • Bug Fix
  • Documentation

Related Issues

Fixes #3056

Test Plan

Unit Tests
Stateless Tests

@nange nange requested a review from BohuTANG as a code owner April 9, 2022 04:38
@vercel
Copy link

vercel bot commented Apr 9, 2022 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/databend/databend/2YCghCQVb7FBupPBLPkZNj44tBoP
✅ Preview: Ignored

@nange
Copy link
Contributor Author

nange commented Apr 9, 2022

/help

@databend-bot
Copy link
Member

/assignme -- assign the issue to you
/review @[username] -- take a reviewer for you
/help -- show help

@mergify
Copy link
Contributor

mergify bot commented Apr 9, 2022

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot added pr-feature this PR introduces a new feature to the codebase pr-bugfix this PR patches a bug in codebase pr-doc-fix labels Apr 9, 2022
@nange
Copy link
Contributor Author

nange commented Apr 9, 2022

/review @sundy-li

@databend-bot databend-bot requested a review from sundy-li April 9, 2022 04:38
@databend-bot
Copy link
Member

Take the reviewer to sundy-li

@BohuTANG
Copy link
Member

BohuTANG commented Apr 9, 2022

Thank you!

@BohuTANG BohuTANG merged commit a279982 into databendlabs:main Apr 9, 2022
@nange nange deleted the feat/regexp_substr_function branch April 9, 2022 06:12
@BohuTANG BohuTANG mentioned this pull request May 12, 2022
Closed
55 tasks
@Xuanwo Xuanwo added this to the v0.8 milestone May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sundy-li sundy-li sundy-li approved these changes

@BohuTANG BohuTANG Awaiting requested review from BohuTANG

Assignees
No one assigned
Labels
community-take need-review pr-bugfix this PR patches a bug in codebase pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Milestone
v0.8
Development

Successfully merging this pull request may close these issues.

REGEXP_SUBSTR() | Return substring matching regular expression
5 participants
@nange @databend-bot @BohuTANG @sundy-li @Xuanwo