Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(functions): support aggregate function retention #4970

Merged
merged 3 commits into from
Apr 21, 2022
Merged

feat(functions): support aggregate function retention #4970

merged 3 commits into from
Apr 21, 2022

Conversation

fkuner
Copy link
Contributor

@fkuner fkuner commented Apr 20, 2022 •
edited
Loading

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

support aggregate function retention

Changelog

  • New Feature
  • Documentation

Related Issues

Fixes #4773

@fkuner fkuner requested a review from BohuTANG as a code owner April 20, 2022 11:10
@vercel
Copy link

vercel bot commented Apr 20, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
databend ⬜️ Ignored (Inspect) Apr 21, 2022 at 5:33AM (UTC)

@mergify
Copy link
Contributor

mergify bot commented Apr 20, 2022

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot added pr-feature this PR introduces a new feature to the codebase pr-doc-fix labels Apr 20, 2022
@BohuTANG BohuTANG requested a review from sundy-li April 20, 2022 11:11
@fkuner fkuner requested review from sundy-li and Xuanwo April 20, 2022 13:54
@fkuner fkuner requested review from sundy-li and Xuanwo April 21, 2022 03:55
Xuanwo
Xuanwo approved these changes Apr 21, 2022
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mergify mergify bot merged commit fb07a2a into databendlabs:main Apr 21, 2022
@sundy-li
Copy link
Member

Congrats on your first contribution!

@fkuner
Copy link
Contributor Author

fkuner commented Apr 21, 2022

Congrats on your first contribution!

Thank you for everyone!

@BohuTANG BohuTANG mentioned this pull request May 12, 2022
Closed
55 tasks
@PsiACE PsiACE mentioned this pull request May 19, 2022
Merged
@Xuanwo Xuanwo added this to the v0.8 milestone May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@b41sh b41sh b41sh left review comments

@Xuanwo Xuanwo Xuanwo approved these changes

@sundy-li sundy-li sundy-li approved these changes

@BohuTANG BohuTANG Awaiting requested review from BohuTANG

Assignees
No one assigned
Labels
need-review pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Milestone
v0.8
Development

Successfully merging this pull request may close these issues.

Feature: support aggregate function retention
5 participants
@fkuner @sundy-li @b41sh @Xuanwo @databend-bot