Feature: impl rename_database with kv-txn #5197
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
|
Thanks for the contribution! Please review the labels and make any necessary changes. |
| @@ -143,6 +146,35 @@ impl RequestHandler<DropDatabaseReq> for ActionHandler { | |||
| } | |||
| } | |||
|
|
|||
| #[async_trait::async_trait] | |||
| impl RequestHandler<RenameDatabaseReq> for ActionHandler { | |||
There was a problem hiding this comment.
This seems not a KV API. Is it the old-way meta API?
There was a problem hiding this comment.
This seems not a KV API. Is it the old-way meta API?
After all meta API has impl by KV api, all the meta handlers in old way will be removed. But now, in order to pass compile, it has to impl with an old way API.
There was a problem hiding this comment.
When renaming a db, it has to assert the dest db-name does not exist.
BTW, this is not a emergency task for now, it is in the postponed task list. Meanwhile the first to do is to replace the old MetaApi impls with the kv-txn based impl. After that, this PR will be simpler to impl too
| let txn_req = TxnRequest { | ||
| condition: vec
Ok. |
I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/
Summary
Feature: impl rename_database with kv-txn
Changelog
Related Issues
Fixes Issue #5192