Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(parser): use datavalues::IntervalType instead of DateTimeField #5373

Merged
merged 5 commits into from
May 14, 2022

Conversation

andylokandy
Copy link
Contributor

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

  • remove DateTimeField and use datavalues::IntervalType instead

Changelog

  • Improvement

@vercel
Copy link

vercel bot commented May 14, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
databend ✅ Ready (Inspect) Visit Preview May 14, 2022 at 11:31AM (UTC)

@mergify
Copy link
Contributor

mergify bot commented May 14, 2022

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@leiysky leiysky requested a review from sundy-li May 14, 2022 08:00
@BohuTANG
Copy link
Member

CI faliure:

test parser::test_statements_in_legacy_suites ... ok

failures:

---- parser::test_expr stdout ----

Goldenfile diff for "expr.txt":
To regenerate the goldenfile, run
    env REGENERATE_GOLDENFILES=1 cargo test
------------------------------------------------------------
---------- Input ----------
a
---------- Output ---------
a
---------- AST ------------
ColumnRef {
    span: [
        Ident(0..1),
    ],
    database: None,
    table: None,
    column: Identifier {
        name: "a",
        quote: None,
        span: Ident(0..1),
    },
}

https://github.com/datafuselabs/databend/runs/6433887445?check_suite_focus=true#step:3:300

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants