Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(planner): Common tree structure formatter for plan display #5512

Merged
merged 2 commits into from
May 23, 2022

Conversation

leiysky
Copy link
Contributor

@leiysky leiysky commented May 23, 2022

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

Introduce a common formatting mechanism for tree stucture, so we can exploit it to imlement EXPLAIN and so on.

A indent format is implemented, here's an example:

PhysicalHashJoin: build keys: [plus(col1, 123)], probe keys: [col2]
    Filter: [true]
        PhysicalScan: catalog.database.table
    PhysicalScan: catalog.database.table

Changelog

  • New Feature

Related Issues

Close #5491

@leiysky leiysky added the C-feature Category: feature label May 23, 2022
@leiysky leiysky requested a review from BohuTANG as a code owner May 23, 2022 03:13
@vercel
Copy link

vercel bot commented May 23, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
databend ⬜️ Ignored (Inspect) May 23, 2022 at 3:13AM (UTC)

@mergify
Copy link
Contributor

mergify bot commented May 23, 2022

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot added the pr-feature this PR introduces a new feature to the codebase label May 23, 2022
@BohuTANG
Copy link
Member

It would be better to add a stateless test for the new explain.

@leiysky
Copy link
Contributor Author

leiysky commented May 23, 2022

It would be better to add a stateless test for the new explain.

EXPLAIN isn't involved in this PR. @xudong963 will support it later.

@BohuTANG BohuTANG merged commit eb07b39 into databendlabs:main May 23, 2022
@leiysky leiysky deleted the plan-formatter branch May 23, 2022 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-feature Category: feature need-review pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Format SExpr into string
4 participants