Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature(planner): Support CREATE TABLE statement in new planner #5771

Merged
merged 2 commits into from
Jun 4, 2022
Merged

feature(planner): Support CREATE TABLE statement in new planner #5771

merged 2 commits into from
Jun 4, 2022

Conversation

leiysky
Copy link
Contributor

@leiysky leiysky commented Jun 4, 2022 •
edited
Loading

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

CREATE TABLE ... AS SELECT ... is blocked by #5780

Changelog

  • New Feature

Related Issues

Close #5735

@vercel
Copy link

vercel bot commented Jun 4, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
databend ⬜️ Ignored (Inspect) Jun 4, 2022 at 4:26PM (UTC)

@leiysky leiysky requested review from sundy-li and zhyass June 4, 2022 12:19
@mergify
Copy link
Contributor

mergify bot commented Jun 4, 2022

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot added the pr-feature this PR introduces a new feature to the codebase label Jun 4, 2022
leiysky
leiysky commented Jun 4, 2022
View reviewed changes
common/planners/src/plan_table_create.rs
@@ -36,7 +35,7 @@ pub struct CreateTablePlan {

pub table_meta: TableMeta,

pub cluster_keys: Vec<Expression>,
pub cluster_keys: Vec<String>,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zhyass I modify this to make it easier to be compatible with new planner, how do you like this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zhyass I modify this to make it easier to be compatible with new planner, how do you like this?

I think it's fine

This was referenced Jun 4, 2022
Closed
Closed
@mergify mergify bot merged commit 7eba93e into databendlabs:main Jun 4, 2022
@leiysky leiysky deleted the create-table branch June 5, 2022 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhyass zhyass zhyass approved these changes

@sundy-li sundy-li sundy-li approved these changes

Assignees
No one assigned
Labels
need-review pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate CREATE TABLE statement to new planner
4 participants
@leiysky @sundy-li @zhyass @databend-bot