Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[meta] feature: protobuf message has to persist MIN_COMPATIBLE_VER in it #5785

Merged
merged 1 commit into from
Jun 5, 2022
Merged

[meta] feature: protobuf message has to persist MIN_COMPATIBLE_VER in it #5785

merged 1 commit into from
Jun 5, 2022

Conversation

drmingdrmer
Copy link
Member

@drmingdrmer drmingdrmer commented Jun 5, 2022 •
edited
Loading

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

[meta] feature: protobuf message has to persist MIN_COMPATIBLE_VER in it

Non-breaking meta-protobuf change.

This way to let old query be able to decide if it is safe to load data
written by a newer query executable.

Changelog

  • New Feature

Related Issues

@vercel
Copy link

vercel bot commented Jun 5, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
databend ⬜️ Ignored (Inspect) Jun 5, 2022 at 6:58AM (UTC)

@drmingdrmer drmingdrmer requested a review from lichuang June 5, 2022 06:42
@mergify
Copy link
Contributor

mergify bot commented Jun 5, 2022

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot added the pr-feature this PR introduces a new feature to the codebase label Jun 5, 2022
@drmingdrmer drmingdrmer requested a review from zhyass June 5, 2022 06:42
@drmingdrmer drmingdrmer marked this pull request as ready for review June 5, 2022 06:42
@BohuTANG
Copy link
Member

BohuTANG commented Jun 5, 2022

This is a breaking change?

@drmingdrmer drmingdrmer mentioned this pull request Jun 5, 2022
Merged
@drmingdrmer
[meta] feature: protobuf message has to persist MIN_COMPATIBLE_VER …
28598be 
…in it

This way to let old query be able to decide if it is safe to load data
written by a newer query executable.

- Fix: databendlabs#5784
@drmingdrmer
Copy link
Member Author

This is a breaking change?

No:)

This PR only affects the query:
It just added a new field into protobuf message. Old query will just ignore this new field when loading new data. New query will have a default value 0 when loading the old data.

zhyass
zhyass approved these changes Jun 5, 2022
View reviewed changes
Copy link
Member

@zhyass zhyass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drmingdrmer
Copy link
Member Author

/lgtm

@mergify mergify bot merged commit 791822d into databendlabs:main Jun 5, 2022
@drmingdrmer drmingdrmer deleted the 15-proto-compat branch June 5, 2022 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@databend-bot databend-bot databend-bot approved these changes

@zhyass zhyass zhyass approved these changes

@lichuang lichuang Awaiting requested review from lichuang

Assignees
No one assigned
Labels
need-review pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

I found there is a flaw in the proto-compatibility:
4 participants
@drmingdrmer @BohuTANG @zhyass @databend-bot